Fix allocator bug for MinGW on Windows#430
Open
Vardan2009 wants to merge 1 commit intoDanielChappuis:masterfrom
Open
Fix allocator bug for MinGW on Windows#430Vardan2009 wants to merge 1 commit intoDanielChappuis:masterfrom
Vardan2009 wants to merge 1 commit intoDanielChappuis:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original code assumed that MSVC is the only C/C++ compiler for Windows, which caused issues when building the library with MinGW. This is just a simple fix changing the
#ifdef RP3D_COMPILER_VISUAL_STUDIOpreprocessor directive to#ifdef RP3D_PLATFORM_WINDOWS